We investigated the expression of thioredoxin and thioredoxin reductase in a large set of breast invasive and in situ carcinomas by immunohistochemistry. Additionally, NF-kappa B, p53 and proliferating cell nuclear antigen (PCNA) expression was studied. Thioredoxin and thioredoxin reductase expression was located in both cytoplasmic and nuclear compartments of the cell. Cytoplasmic thioredoxin positivity was found in 67 % and nuclear in 59 % of the cases, while thioredoxin reductase was found in 55 % and 6 % of cases, respectively. Ductal carcinomas showed stronger cytoplasmic thioredoxin immunoreactivity than lobular ones. Nuclear thioredoxin positivity was more often found in in situ lesions, and lobular carcinomas were more often negative than ductal ones. Both cytoplasmic and nuclear thioredoxin-positive cases had a high proliferation measured by PCNA staining. Positive nuclear immunostaining was associated with negative estrogen and progesterone receptor status. Cases with high p53 expression showed significantly higher nuclear thioredoxin positivity, but lower thioredoxin reductase positivity. Whilst thioredoxin or thioredoxin reductase was not associated with patient survival, cases showing both cytoplasmic and nuclear thioredoxin reductase-positive tumours had a shorter disease-free interval than those with negative immunostaining.