To elucidate the role of X-ray repair cross-complementing group 1 (XRCC1) R399Q and R194W genotypes in bladder cancer risk, all available studies were considered in the present meta-analysis, with 4152 patients and 5372 controls for R399Q and 3215 patients and 4313 controls for R194W. Studies were identified in PubMed up to June 2008. Overall, the 399Q allele showed no significant effect on bladder cancer compared to 399R allele in all subjects. Insignificant association between R399Q and bladder cancer was observed under other genetic contrasts in worldwide population, Caucasians and never-smokers. Among ever-smokers, protective effects of 399QQ genotype were observed under recessive model [P = 0.004, fixed-effects (FEs) model odds ratio (OR) = 0.65; 95% confidence interval (CI) (0.49, 0.86), I(2) = 0% P(heterogeneity) = 0.57] and homozygote contrast (P = 0.01, FE OR = 0.66; 95% CI (0.49, 0.90), I(2) = 0%, P(heterogeneity) = 0.76). No apparent effect of 194W allele compared to 194R on bladder cancer risk was found in all subjects and Caucasians. It indicated that XRCC1 R399Q and R194W might not be risk factors to bladder cancer, but the 399QQ genotype decreased susceptibility of bladder cancer under recessive model and homozygote contrast among ever-smokers. Further studies based on larger, stratified population were required to explore the role of XRCC1 polymorphisms in bladder cancer risk.