The pathogenesis of renal calculi is reviewed in general terms followed by the results of investigation of 439 patients with renal calculi studied by the author at Toronto General Hospital over a 13-year period. Abnormalities of probable pathogenetic significance were encountered in 76% of patients. Idiopathic hypercalciuria was encountered in 42% of patients, primary hyperparathyroidism in 11%, urinary infection in 8% and miscellaneous disorders in 8%. The incidence of uric acid stones and cystinuria was 5% and 2% respectively. In the remaining 24% of patients in whom no definite abnormalities were encountered the mean urinary magnesium excretion was less than normal. Of 180 patients with idiopathic hypercalciuria, only 24 were females. In the diagnosis of hyperparathyroidism, the importance of detecting minimal degrees of hypercalcemia is stressed; attention is also drawn to the new observation that the upper limit of normal for serum calcium is slightly lower in females than in males. The efficacy of various measures advocated for the prevention of renal calculi is also reviewed. In the author's experience the administration of thiazides has been particularly effective in the prevention of calcium stones. Thiazides cause a sustained reduction in urinary calcium excretion and increase in urinary magnesium excretion. These agents also appear to affect the skeleton by diminishing bone resorption and slowing down bone turnover.